leonardBang commented on pull request #13128: URL: https://github.com/apache/flink/pull/13128#issuecomment-696498920
One more tip, that's great if we could add e2e test for `hbase 2` just like kafka support multiple versions e2e test, we can keep `hbase 2` test once we decided to deprecate the `hbase 1` https://github.com/apache/flink/blob/607919c6ea6983ae5ad3f82d63b7d6455c73d225/flink-end-to-end-tests/flink-end-to-end-tests-hbase/src/test/resources/hbase_e2e.sql#L22 https://github.com/apache/flink/blob/607919c6ea6983ae5ad3f82d63b7d6455c73d225/flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/src/test/resources/kafka_e2e.sql#L23 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
