rmetzger commented on a change in pull request #13424:
URL: https://github.com/apache/flink/pull/13424#discussion_r493250572



##########
File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/DispatcherJob.java
##########
@@ -165,17 +171,10 @@ private DispatcherJob(
                        if (isInitialized()) {
                                return 
getJobMasterGateway().thenCompose(jobMasterGateway -> 
jobMasterGateway.cancel(timeout));
                        } else {
-                               log.info("Cancellation during initialization 
requested for job {}. Job will be cancelled once JobManager has been 
initialized.", jobId);
+                               log.info("Cancellation during initialization 
for job {}.", jobId);

Review comment:
       Let me try again: I believe it is relevant enough because we are 
interrupting the initialization thread, potentially leading to all kinds of 
weird errors. I should change the log message a bit to make that more explicit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to