dawidwys commented on a change in pull request #13443:
URL: https://github.com/apache/flink/pull/13443#discussion_r493757206
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimerServiceSerializationProxy.java
##########
@@ -38,7 +38,7 @@
public static final int VERSION = 2;
/** The key-group timer services to write / read. */
- private final InternalTimeServiceManager<K> timerServicesManager;
+ private final InternalTimeServiceManagerImpl<K> timerServicesManager;
Review comment:
The thing though is, this "proxy" is used exclusively in the a private
method of the `InternalTimerServiceManagerImpl` and is specific for that
particular implementation. Therefore I think it is fine to use the *impl calss
directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
