tzulitai commented on pull request #152: URL: https://github.com/apache/flink-statefun/pull/152#issuecomment-698128903
@galenwarren one comment about addressing PR reviews, for consideration in future contributions: I find it best (and also recommended by the Flink contribution guide) to address PR comments with follow-up commits on the PR branch, instead of squashing + rebasing + force-pushing. That way changes since the last review will be separate commits and will allow the reviewer to more easily track the changes. Usually committers will be rebasing + squashing the follow-up commits when merging for you. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
