SteNicholas opened a new pull request #13471:
URL: https://github.com/apache/flink/pull/13471
## What is the purpose of the change
*Both `getAccumulators()` and `getJobExecutionResult()` result require the
user to give a `ClassLoader`. `JobClient` created in a context could get the
user-code `ClassLoader` by `PipelineExecutor`. `ClassLoader` parameter should
be removed from those methods and require that users could give the user-code
class loader when constructing a `JobClient` themselves for an already running
job.*
## Brief change log
- *`getAccumulators()` and `getJobExecutionResult()` of `JobClient` remove
the user-code `ClassLoader` parameter.*
- *Constructor of `ClusterClientJobClientAdapter`, `EmbeddedJobClient`,
`PerJobMiniClusterJobClient` and `WebSubmissionJobClient` for`JobClient`
implementations add `ClassLoader` parameter.*
- *Caller of `getAccumulators()` and `getJobExecutionResult()` removes the
user-code `ClassLoader` adapt to the modified API of `JobClient`.*
## Verifying this change
- *Test cases related to `getAccumulators()` and `getJobExecutionResult()`
of `JobClient` could verify the case that removes the user-code `ClassLoader`
parameter.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (**yes** / no)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
