Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53281258
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/CassandraMapperSink.java
---
@@ -0,0 +1,86 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.connectors.cassandra.streaming;
+
+import java.io.Serializable;
+
+import org.apache.flink.configuration.Configuration;
+
+import com.datastax.driver.mapping.MappingManager;
+import com.datastax.driver.mapping.Mapper;
+import com.google.common.base.Preconditions;
+import com.google.common.util.concurrent.ListenableFuture;
+import
org.apache.flink.connectors.cassandra.streaming.examples.WriteCassandraMapperSink;
+
+/**
+ * Flink Sink to save data into a Cassandra cluster using {@link Mapper},
which
+ * it uses annotations from {@link com.datastax.driver.mapping}. See
example.
+ * {@link WriteCassandraMapperSink }
+ *
+ * @param <IN> Type of the elements emitted by this
sink
+ */
+public abstract class CassandraMapperSink<IN extends Serializable> extends
+ BaseCassandraSink<IN,Void> {
+
+ private static final long serialVersionUID = 1L;
+
+ protected Class<IN> clazz;
+
+ protected transient Mapper<IN> mapper;
+
+ protected transient MappingManager mappingManager;
+
+ /**
+ * Constructor for creating a CassandraMapperSink
+ *
+ * @param clazz Class<IN> instance
+ */
+ public CassandraMapperSink(Class<IN> clazz) {
+ this(null, clazz);
+ }
+
+
+ /**
+ * The main constructor for creating CassandraMapperSink
+ *
+ * @param createQuery Query to create dynamically a Table into
Cassandra
+ * @param clazz Class<IN> instance
+ */
+ public CassandraMapperSink(String createQuery, Class<IN> clazz) {
+ super(createQuery);
+ Preconditions.checkNotNull(clazz, "Clazz cannot be null");
+ this.clazz = clazz;
+ }
+
+ @Override
+ public void open(Configuration configuration) {
+ super.open(configuration);
+ try {
+ this.mappingManager = new MappingManager(session);
+ this.mapper = mappingManager.mapper(clazz);
+ } catch (Exception e) {
+ logError(e.getMessage());
--- End diff --
when you throw an exception anyway we don't need to log anything.
regardless, the usage of logError is inconsistent, it is only used in this
method, although you log things at other places.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
