AHeise commented on a change in pull request #13465:
URL: https://github.com/apache/flink/pull/13465#discussion_r494396603
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/BlockableInput.java
##########
@@ -26,9 +26,12 @@
/**
* Input, with just basic methods for blocking and resuming consumption. It
can be for example an {@link InputGate}
+ * or a chained source.
*/
@Internal
public interface BlockableInput {
+ void blockConsumption(int inputChannelIdx);
+
void resumeConsumption(int channelIndex) throws IOException;
Review comment:
`resumeConsumption` could be implicitly triggered by `checkpointStopped`.
Then, the last unfitting method is `blockConsumption`, which could be
modeled as `void barrierReceived(int channelIndex, CheckpointBarrier barrier);`
(and it wouldn't be odd that it's ignored by InputGate).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
