[ 
https://issues.apache.org/jira/browse/FLINK-19395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202000#comment-17202000
 ] 

Timo Walther commented on FLINK-19395:
--------------------------------------

Thanks [~ShawnHx]. I assigned you to this issue. Please replace all 
`unsupported` or `unexpected` exceptions with `TableException` and invalid user 
input with `ValidationException`.

> Replace SqlConversionException with either TableException or 
> ValidationException
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-19395
>                 URL: https://issues.apache.org/jira/browse/FLINK-19395
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Legacy Planner, Table SQL / Planner
>            Reporter: Timo Walther
>            Assignee: Xiao Huang
>            Priority: Major
>              Labels: starter
>
> We should avoid creating too many different exceptions without reason. 
> `SqlConversionException` is not necessary and can be replaced by the two 
> commonly used exceptions for TableException or ValidationException. 
> Currently, we throw all three in `SqlToOperation` converters.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to