shuiqiangchen commented on a change in pull request #13327:
URL: https://github.com/apache/flink/pull/13327#discussion_r494773270
##########
File path: flink-python/pyflink/fn_execution/coders.py
##########
@@ -467,8 +478,8 @@ def from_proto(field_type):
if field_type_name == type_name.LOCAL_ZONED_TIMESTAMP:
timezone = pytz.timezone(os.environ['table.exec.timezone'])
return
LocalZonedTimestampCoder(field_type.local_zoned_timestamp_info.precision,
timezone)
- elif field_type_name == type_name.ARRAY:
- return ArrayCoder(from_proto(field_type.collection_element_type))
+ elif field_type_name == type_name.BASIC_ARRAY:
Review comment:
In SQL/ Table API, the array type is the BasicArrayType,
PrimitiveArrayType is not considered.
##########
File path: flink-python/pyflink/fn_execution/beam/beam_coders.py
##########
@@ -194,7 +194,7 @@ def _to_data_type(field_type):
field_type.nullable)
elif field_type.type_name ==
flink_fn_execution_pb2.Schema.TIMESTAMP:
return TimestampType(field_type.timestamp_info.precision,
field_type.nullable)
- elif field_type.type_name == flink_fn_execution_pb2.Schema.ARRAY:
Review comment:
In SQL/ Table API, the array type is the BasicArrayType,
PrimitiveArrayType is not considered.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
