HuangXingBo commented on a change in pull request #13475:
URL: https://github.com/apache/flink/pull/13475#discussion_r494767434
##########
File path: flink-python/pyflink/fn_execution/beam/beam_operations_fast.pyx
##########
@@ -192,6 +194,108 @@ cdef class
PandasAggregateFunctionOperation(BeamStatelessFunctionOperation):
return generate_func, user_defined_funcs
+cdef class
PandasBatchOverWindowAggregateFunctionOperation(BeamStatelessFunctionOperation):
Review comment:
I think it is necessary to re-layer the existing operations to be able
to achieve only one python implementation at the bottom layer or cython
implementation at the same time. I suggest to solve this problem separately in
other PRs. What do you think?
##########
File path: flink-python/pyflink/fn_execution/beam/beam_operations_fast.pyx
##########
@@ -192,6 +194,108 @@ cdef class
PandasAggregateFunctionOperation(BeamStatelessFunctionOperation):
return generate_func, user_defined_funcs
+cdef class
PandasBatchOverWindowAggregateFunctionOperation(BeamStatelessFunctionOperation):
Review comment:
Of course. I have created a JIRA
https://issues.apache.org/jira/browse/FLINK-19412 to track it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
