aljoscha commented on a change in pull request #13471:
URL: https://github.com/apache/flink/pull/13471#discussion_r494385888
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/application/executors/EmbeddedExecutorFactory.java
##########
@@ -79,9 +79,9 @@ public PipelineExecutor getExecutor(final Configuration
configuration) {
return new EmbeddedExecutor(
submittedJobIds,
dispatcherGateway,
- jobId -> {
+ (jobId, userCodeClassloader) -> {
Review comment:
The indentation seems off here, should be on the same level as the other
parameters.
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/application/WebSubmissionJobClient.java
##########
@@ -43,7 +43,7 @@
private final JobID jobId;
- public WebSubmissionJobClient(final JobID jobId) {
+ public WebSubmissionJobClient(final JobID jobId, final ClassLoader
userCodeClassloader) {
Review comment:
The `userCodeClassloader` is not used so the parameter doesn't need to
be added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
