Jiayi-Liao commented on a change in pull request #11509:
URL: https://github.com/apache/flink/pull/11509#discussion_r495735775
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnable.java
##########
@@ -197,7 +199,8 @@ private void handleExecutionException(Exception e) {
// We only report the exception for the
original cause of fail and cleanup.
// Otherwise this followup exception could race
the original exception in failing the task.
try {
-
taskEnvironment.declineCheckpoint(checkpointMetaData.getCheckpointId(),
checkpointException);
+
taskEnvironment.declineCheckpoint(checkpointMetaData.getCheckpointId(),
+ new
CheckpointException(CheckpointFailureReason.EXCEPTION, checkpointException));
Review comment:
* `CheckpointFailureReason.JOB_FAILURE` is the default value of method
`getCheckpointException`, you can check the implementation for more details.
* You're right about this. In our internal version we add a new
`CheckpointFailureReason` value:
```
CHECKPOINT_ASYNC_EXCEPTION(false, "Asynchronous task checkpoint failed."),
```
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnable.java
##########
@@ -197,7 +199,8 @@ private void handleExecutionException(Exception e) {
// We only report the exception for the
original cause of fail and cleanup.
// Otherwise this followup exception could race
the original exception in failing the task.
try {
-
taskEnvironment.declineCheckpoint(checkpointMetaData.getCheckpointId(),
checkpointException);
+
taskEnvironment.declineCheckpoint(checkpointMetaData.getCheckpointId(),
+ new
CheckpointException(CheckpointFailureReason.EXCEPTION, checkpointException));
Review comment:
@zhijiangW
* `CheckpointFailureReason.JOB_FAILURE` is the default value of method
`getCheckpointException`, you can check the implementation for more details.
* You're right about this. In our internal version we add a new
`CheckpointFailureReason` value:
```
CHECKPOINT_ASYNC_EXCEPTION(false, "Asynchronous task checkpoint failed."),
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
