AHeise commented on a change in pull request #13499:
URL: https://github.com/apache/flink/pull/13499#discussion_r496477506
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
##########
@@ -92,16 +102,21 @@
private final int maxBuffersPerChannel;
+ @GuardedBy("availableMemorySegments")
private final int[] subpartitionBuffersCount;
private final BufferRecycler[] subpartitionBufferRecyclers;
+ @GuardedBy("availableMemorySegments")
private int unavailableSubpartitionsCount = 0;
private boolean isDestroyed;
+ @GuardedBy("availableMemorySegments")
private final AvailabilityHelper availabilityHelper = new
AvailabilityHelper();
+ private volatile boolean eagerlyRequesting;
Review comment:
I'll try to get rid of it. Probably also premature optimization (cheap
read-lock).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
