zhijiangW commented on a change in pull request #11509:
URL: https://github.com/apache/flink/pull/11509#discussion_r496653711
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsyncCheckpointRunnable.java
##########
@@ -197,7 +199,8 @@ private void handleExecutionException(Exception e) {
// We only report the exception for the
original cause of fail and cleanup.
// Otherwise this followup exception could race
the original exception in failing the task.
try {
-
taskEnvironment.declineCheckpoint(checkpointMetaData.getCheckpointId(),
checkpointException);
+
taskEnvironment.declineCheckpoint(checkpointMetaData.getCheckpointId(),
+ new
CheckpointException(CheckpointFailureReason.EXCEPTION, checkpointException));
Review comment:
I think the first one is necessary since the type of thrown exception is
changed in this PR.
The second one is optional since we do not change any logics there. But if
you want to supplement some previously missing unit tests for the
`CheckpointCoordinator` component, I am also fine with it. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
