[
https://issues.apache.org/jira/browse/FLINK-3248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15152810#comment-15152810
]
ASF GitHub Bot commented on FLINK-3248:
---------------------------------------
GitHub user mxm opened a pull request:
https://github.com/apache/flink/pull/1670
[FLINK-3248] add constructor params and generic ConnectionFactory
This adds more default constructor parameters to the RMQSource. In addition,
users may override the setupConnectionFactory() method to return their own
configured factory.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mxm/flink FLINK-3248
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1670.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1670
----
commit 3795ba62e1cbc825329238669d5a79490bde1ced
Author: Maximilian Michels <[email protected]>
Date: 2016-02-17T09:34:01Z
[FLINK-3248] add constructor params and generic ConnectionFactory
This adds more default constructor parameters to the RMQSource. In addition,
users may override the setupConnectionFactory() method to return their onwn
configured factory.
commit 4112074f6340e57d66fe38fa203748a93d39ad88
Author: Maximilian Michels <[email protected]>
Date: 2016-02-18T16:33:00Z
remove RMQTopology file
----
> RMQSource does not provide a constructor for credentials or other options
> -------------------------------------------------------------------------
>
> Key: FLINK-3248
> URL: https://issues.apache.org/jira/browse/FLINK-3248
> Project: Flink
> Issue Type: Bug
> Components: Streaming Connectors
> Affects Versions: 1.0.0
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Fix For: 1.0.0
>
>
> We could either add a new constructor for credentials (username and password)
> or let the user pass a {{ConnectionFactory}} to the source. The latter would
> enable us to support all potential options for the connection. Note that,
> {{ConnectionFactory}} is not serializable. It would have to be serialized to
> a byte array for shipping.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
