aljoscha commented on pull request #13509:
URL: https://github.com/apache/flink/pull/13509#issuecomment-701246107
Thanks for the reviews!
@dawidwys I didn't try removing `setStreamTimeCharacteristic` but I manually
checked the references. There are a couple of clusters where it's still used:
- tests that verify explicit behaviour based on the characteristic, for
example in the Table Planner tests or the time window translation tests
- CEP tests, but there's a follow-up issue for addressing that:
https://issues.apache.org/jira/browse/FLINK-19326
- time interval join (tests), unfortunately they also magically change
behaviour based on the characteristic:
https://issues.apache.org/jira/browse/FLINK-19479
@kl0u I'm also torn on deprecating `TimeCharacteristic` because we still use
it internally. I did deprecate it because that's the message we want to send.
What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
