StephanEwen commented on a change in pull request #13512: URL: https://github.com/apache/flink/pull/13512#discussion_r497451444
########## File path: flink-core/src/test/java/org/apache/flink/api/connector/source/lib/NumberSequenceSourceTest.java ########## @@ -0,0 +1,91 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.api.connector.source.lib; + +import org.apache.flink.api.connector.source.SourceReader; +import org.apache.flink.api.connector.source.mocks.TestingReaderContext; +import org.apache.flink.api.connector.source.mocks.TestingReaderOutput; +import org.apache.flink.core.io.InputStatus; + +import org.junit.Test; + +import java.util.Arrays; +import java.util.List; + +import static org.junit.Assert.fail; + +/** + * Tests for the {@link NumberSequenceSource}. + */ +public class NumberSequenceSourceTest { + + @Test + public void testReaderCheckpoints() throws Exception { Review comment: I was contemplating this and decided against that, as mentioned in the PR description. The Integration Test would mostly test the runtime source operator and coordinator, not specific to this source here. Having at least one case of the source being used end to end makes total sense, and this is the case in other tests (see for example #13513) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
