AHeise commented on a change in pull request #13499:
URL: https://github.com/apache/flink/pull/13499#discussion_r497481526
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java
##########
@@ -296,6 +296,11 @@ private MemorySegment requestMemorySegment(int
targetChannel) {
synchronized (availableMemorySegments) {
returnExcessMemorySegments();
+ // target channel over quota; do not return a segment
Review comment:
Yes it changes
`LocalBufferPoolTest#testMaxBuffersPerChannelAndAvailability`. Other test
played nicely (only took buffer they should have taken).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]