pnowojski edited a comment on pull request #11502:
URL: https://github.com/apache/flink/pull/11502#issuecomment-701401023


   There are some test failures, probably unrelated ( 
https://issues.apache.org/jira/browse/FLINK-19295 ) however as you @Jiayi-Liao 
are modified logging, `ensureNoProhibitedStringInLogFiles` doesn't sound like 
can be ignored.
   
   Could you:
   1. squash the changes into one commit
   either
   2a. wait until https://github.com/apache/flink/pull/13439 is merged and 
rebase on top of the master
   or
   2b. rebase on top of it now, and includes it's commits into your PR?
   
   After doing 2a. or 2b., if azure is green I could merge this (if anyone 
would rise an objection, it can be always reverted later).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to