kezhuw commented on a change in pull request #13375:
URL: https://github.com/apache/flink/pull/13375#discussion_r498570772
##########
File path:
flink-core/src/main/java/org/apache/flink/core/fs/SafetyNetCloseableRegistry.java
##########
@@ -134,10 +135,17 @@ public void close() throws IOException {
--GLOBAL_SAFETY_NET_REGISTRY_COUNT;
if (0 == GLOBAL_SAFETY_NET_REGISTRY_COUNT) {
REAPER_THREAD.interrupt();
Review comment:
All reclamation related classes and methods, say,
`CloseableReaperThread`, `PhantomDelegatingCloseableRef` and
`SafetyNetCloseableRegistry(Supplier<CloseableReaperThread>
reaperThreadSupplier)`, are private or visible for testing, normal clients
should care only about the reclamation of leaking resources guarantee exported
by `SafetyNetCloseableRegistry`, "join on the reaper thread" does not
contribute to that exported guarantee.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
