kl0u commented on a change in pull request #13531:
URL: https://github.com/apache/flink/pull/13531#discussion_r499506498
##########
File path: docs/dev/stream/experimental.md
##########
@@ -60,7 +60,7 @@ Code example:
StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
DataStreamSource<Integer> source = ...
DataStreamUtils.reinterpretAsKeyedStream(source, (in) -> in,
TypeInformation.of(Integer.class))
- .timeWindow(Time.seconds(1))
+ .window(TumblingEventTimeWindows.of(Time.seconds(1)))
Review comment:
Same as above in both.
##########
File path: docs/dev/parallel.md
##########
@@ -55,7 +55,7 @@ DataStream<String> text = [...]
DataStream<Tuple2<String, Integer>> wordCounts = text
.flatMap(new LineSplitter())
.keyBy(value -> value.f0)
- .timeWindow(Time.seconds(5))
+ .window(TumblingEventTimeWindows.of(Time.seconds(5)))
.sum(1).setParallelism(5);
Review comment:
For all of these changes, same as above about event vs processing time.
##########
File path: docs/dev/stream/operators/windows.md
##########
@@ -684,7 +684,7 @@ DataStream<Tuple2<String, Long>> input = ...;
input
.keyBy(t -> t.f0)
- .timeWindow(Time.minutes(5))
+ .window(TumblingEventTimeWindows.of(Time.minutes(5)))
Review comment:
Same as above.
##########
File path: README.md
##########
@@ -41,7 +41,7 @@ val text = env.socketTextStream(host, port, '\n')
val windowCounts = text.flatMap { w => w.split("\\s") }
.map { w => WordWithCount(w, 1) }
.keyBy("word")
- .timeWindow(Time.seconds(5))
+ .window(TumblingEventTimeWindow.of(Time.seconds(5)))
Review comment:
I think here it will not work without a `WatermarkStrategy`, right? If
this is correct, we should maybe put processing time window.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
