[
https://issues.apache.org/jira/browse/FLINK-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154834#comment-15154834
]
ASF GitHub Bot commented on FLINK-3439:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1677#discussion_r53515589
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/timestamp/TimestampITCase.java
---
@@ -157,13 +157,6 @@ public void testWatermarkPropagation() throws
Exception {
Assert.fail("Wrong watermark.");
}
}
- if
(!CustomOperator.finalWatermarks[i].get(CustomOperator.finalWatermarks[i].size()
- 1).equals(new Watermark(Long.MAX_VALUE))) {
--- End diff --
Let's add a test here that validates that this `Long.MAX_VALUE` watermark
is not present. Something like `assertEquals(NUM_WATERMARKS,
CustomOperator.finalWatermarks[i].size())`
> Remove final Long.MAX_VALUE Watermark in StreamSource
> -----------------------------------------------------
>
> Key: FLINK-3439
> URL: https://issues.apache.org/jira/browse/FLINK-3439
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
>
> I think this was an oversight. At one point we decided to not emit in-flight
> windows when closing the topology or sources.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
