AHeise commented on a change in pull request #13545: URL: https://github.com/apache/flink/pull/13545#discussion_r500325899
########## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/UnexpectedStateHandleException.java ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state; + +import org.apache.flink.shaded.guava18.com.google.common.base.Joiner; + +/** + * Signals that an operation did not get the type of {@link StateObject} that was expected. This can + * mostly happen when a different {@link StateBackend} from the one that was used for taking a + * checkpoint/savepoint is used when restoring. + */ +public class UnexpectedStateHandleException extends IllegalStateException { Review comment: If we could find a good place for such a method, I'd prefer a method. But if not (like adding a new Util class), leave as is. The only place that I could think of is to add a static method to `RestoreOperation`. ########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/state/UnexpectedStateHandleExceptionTest.java ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.state; + +import org.junit.Test; + +import static org.hamcrest.CoreMatchers.containsString; +import static org.junit.Assert.assertThat; + +/** + * Tests for {@link UnexpectedStateHandleException}. + */ +public class UnexpectedStateHandleExceptionTest { Review comment: Hm, I'm not sure what the value of the current tests are. If I add a linebreak to the message formatting at some point, I'd need to touch both tests. But I also don't insist on the ITCase: Since you didn't change anything on the exception logic (just using a subclass), I'm fine to leave as is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
