XComp commented on pull request #13547:
URL: https://github.com/apache/flink/pull/13547#issuecomment-704310910
Another thing that's up for discussion: The current implementation does
provide redundant information in the REST API.
```
{
"id": "192.168.178.34:58646-64d0d8",
"path": "akka.tcp://[email protected]:58646/user/rpc/taskmanager_0",
"dataPort": 58648,
"jmxPort": -1,
"timeSinceLastHeartbeat": 1601994279165,
"slotsNumber": 1,
"freeSlots": 0,
"totalResource": {
"cpuCores": 0,
"taskHeapMemory": 0,
"taskOffHeapMemory": 0,
"managedMemory": 0,
"networkMemory": 0,
"extendedResources": {}
},
"freeResource": {
"cpuCores": 0,
"taskHeapMemory": 0,
"taskOffHeapMemory": 0,
"managedMemory": 0,
"networkMemory": 0,
"extendedResources": {}
},
"hardware": {
"cpuCores": 12,
"physicalMemory": 17179869184,
"freeMemory": 536805376,
"managedMemory": 536870920 <-- redundant
},
"memoryConfiguration": {
"frameworkHeap": 134217728,
"taskHeap": 402653174,
"frameworkOffHeap": 134217728,
"taskOffHeap": 0,
"networkMemory": 134217730,
"managedMemory": 536870920, <-- redundant
"jvmMetaspace": 268435456,
"jvmOverhead": 1073741824,
"totalFlinkMemory": null,
"totalProcessMemory": 1811939328
},
"metrics": {
"heapUsed": 119710848,
"heapCommitted": 536805376,
"heapMax": 536805376,
"nonHeapUsed": 70984004,
"nonHeapCommitted": 455180084,
"nonHeapMax": -1,
"directCount": 4115,
"directUsed": 134750413,
"directMax": 134750412,
"mappedCount": 0,
"mappedUsed": 0,
"mappedMax": 0,
"memorySegmentsAvailable": 4092,
"memorySegmentsTotal": 4096,
"nettyShuffleMemorySegmentsAvailable": 4092,
"nettyShuffleMemorySegmentsUsed": 4,
"nettyShuffleMemorySegmentsTotal": 4096,
"nettyShuffleMemoryAvailable": 134086656,
"nettyShuffleMemoryUsed": 131072,
"nettyShuffleMemoryTotal": 134217728,
"managedMemoryAvailable": 536870920,
"managedMemoryUsed": 0,
"managedMemoryTotal": 536870920, <-- redundant
"garbageCollectors": [
{
"name": "scavenge",
"count": 2,
"time": 21
},
{
"name": "global",
"count": 0,
"time": 0
}
]
}
}
```
The example above shows that `metrics.managedMemoryTotal`,
`memoryConfiguration.managedMemory`, and `hardware.managedMemory` are showing
the same value. At least, `hardware.managedMemory` seems to be out of place.
IMHO, we could remove it as part of this PR. Not sure about the other two,
though, since it's kind of standardized.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
