aljoscha opened a new pull request #13554: URL: https://github.com/apache/flink/pull/13554
## What is the purpose of the change Before, it was up to the `CustomCommandLine` implementation whether any `Configuration` was passed through from the flink-conf.yaml or wherever the base `Configuration` came from. Now, we make the flow of the `Configuration` explicit in `CliFrontend.getEffectiveConfiguration()`. Instead of relying on the `Configuration` we get from the `CustomCommandLine` we ask the `CustomCommandLine` to materialize its settings and add them manually to an effective `Configuration` that the `CliFrontend` controls. This removes the `Configuration` parameter from `CustomCommandLines` that don't need it anymore, such as `DefaultCLI`, which means we also have to touch tests. Also, the test for `DefaultCLI` is vastly simplified because the behaviour we were testing there is now in the new ITCase. This adds a new integration test in `CliFrontendITCase` that verifies correct parameter passing and also verifies that command line arguments override base settings I'm also addressing https://issues.apache.org/jira/browse/FLINK-19521 here because I noticed and filed that during implementation. It's a small change but should make the CLI more consistent. ## Verifying this change - A new ITCase was added. - Added test for dynamic properties on `DefaultCLI` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? yes, dynamic properties for the DefaultCLI - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
