pnowojski commented on a change in pull request #13529:
URL: https://github.com/apache/flink/pull/13529#discussion_r501809876
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamOneInputProcessor.java
##########
@@ -62,6 +62,16 @@ public StreamOneInputProcessor(
return input.getAvailableFuture();
}
+ @Override
+ public boolean isAvailable() {
+ return input.isAvailable();
+ }
+
+ @Override
+ public boolean isApproximatelyAvailable() {
+ return input.isApproximatelyAvailable();
+ }
+
Review comment:
Why do we need this commit? The default implementations should be doing
the same thing.
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/StreamOneInputProcessor.java
##########
@@ -45,16 +45,16 @@
private final StreamTaskInput<IN> input;
private final DataOutput<IN> output;
- private final OperatorChain<?, ?> operatorChain;
+ private final BoundedMultiInput endOfInputAware;
public StreamOneInputProcessor(
StreamTaskInput<IN> input,
DataOutput<IN> output,
- OperatorChain<?, ?> operatorChain) {
+ BoundedMultiInput endOfInputAware) {
Review comment:
nit: it would be nice to keep the remaining processors in sync with this
change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
