zentol commented on a change in pull request #13553:
URL: https://github.com/apache/flink/pull/13553#discussion_r502364278
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -861,6 +884,8 @@ protected void closeJobManagerConnection(JobID jobId,
Exception cause) {
jmResourceIdRegistrations.remove(jobManagerResourceId);
+
slotManager.processResourceRequirements(ResourceRequirements.empty(jobId,
jobMasterGateway.getAddress()));
Review comment:
hmm...i think the current behavior is fine for the case where a JM just
crashes, but when we have HA _I think_ we are also clearing the requirements
when the leader lost leadership.
Soo...`removeJob` may be a better place to put it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
