[ 
https://issues.apache.org/jira/browse/FLINK-3459?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15156777#comment-15156777
 ] 

ASF GitHub Bot commented on FLINK-3459:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/flink/pull/1682#issuecomment-187125611
  
    I tested this change and #1681 on a HDP cluster and Flink started 
successfully on YARN.
    I know that this one test is certainly not sufficient to guarantee that it 
works on all Hadoop distributions.
    
    +1 to merge.


> Make build SBT compatible
> -------------------------
>
>                 Key: FLINK-3459
>                 URL: https://issues.apache.org/jira/browse/FLINK-3459
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Minor
>             Fix For: 1.0.0
>
>
> The current flink-shaded-hadoop2 dependency is not SBT compatible because it 
> contains {{commons-collection:3.2.1}}, {{commons-beanutils:1.7}} and 
> {{commons-beanutils-core:1.8}} dependencies. These dependencies contain 
> overlapping classes which are binary compatible but not binary identical. 
> This is a problem for the SBT assembly plugin which requires binary identity 
> for merging them. Otherwise, the build is aborted. I propose to exclude the 
> conflicting dependencies and use instead the 
> {{commons-beanutils-bean-collection}} class which contains only then 
> non-conflicting classes.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to