WeiZhong94 commented on a change in pull request #13507:
URL: https://github.com/apache/flink/pull/13507#discussion_r503096233
##########
File path: flink-python/pyflink/common/types.py
##########
@@ -37,7 +37,7 @@ def _create_row(fields, values, row_kind: RowKind = None):
return row
-class Row(tuple):
+class Row(object):
Review comment:
We need an updatable Row for implementing DataViews, but the tuple is
read-only.
##########
File path: flink-python/pyflink/common/types.py
##########
@@ -82,21 +82,18 @@ class Row(tuple):
Row(name='Alice', age=11)
"""
- def __new__(cls, *args, **kwargs):
Review comment:
The example in the doc still works except the usage of the "in"
keyword. These changes make the Row object updatable and would not break the
legacy code so I think they are accpetable.
##########
File path: flink-python/pyflink/fn_execution/beam/beam_operations_slow.py
##########
@@ -304,9 +306,6 @@ def finish(self):
def reset(self):
super().reset()
- if self.keyed_state_backend:
Review comment:
The reset method would be called between the "open" method and
"process_element" method of the GroupAggFunction so we should not reset the
keyed_state_backend here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
