wuchong commented on a change in pull request #13570:
URL: https://github.com/apache/flink/pull/13570#discussion_r503155496
##########
File path:
flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableFactory.java
##########
@@ -109,6 +109,11 @@
.withDescription("gives the reader a hint as to the number of
rows that should be fetched, from" +
" the database when reading per round trip. If the
value specified is zero, then the hint is ignored. The" +
" default value is zero.");
+ private static final ConfigOption<Boolean> SCAN_AUTO_COMMIT =
ConfigOptions
+ .key("scan.auto-commit")
+ .booleanType()
+ .noDefaultValue()
Review comment:
In the mailing list, I had made a mistake that I thought the
`autoCommit` is false by default in `JdbcRowDataInputFormat.Builder` (but it is
null by default), so I said it should be true by default. As for now, I think
we don't need to add a patch to branch 1.11 because this is not a bug, but is a
new feature.
I think it would be more reasonable to make auto commit default true
everywhere. The behavior of JDBC connector should match JDBC driver default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
