pnowojski commented on a change in pull request #13565:
URL: https://github.com/apache/flink/pull/13565#discussion_r503809655
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PendingCheckpoint.java
##########
@@ -531,6 +527,30 @@ private void dispose(boolean releaseState,
CheckpointsCleaner checkpointsCleaner
}
}
+ @Override
+ public void discard() {
+ synchronized (lock) {
+ if (stateDiscarded) {
+ Preconditions.checkState(discarded, "Checkpoint
should be disposed before being discarded");
+ return;
+ } else {
+ stateDiscarded = true;
+ }
+ }
Review comment:
Ok, I think I get it now. Now it's a public method so you are protecting
it more.
I think I would prefer:
1. rename `discarded` -> `disposed` or `scheduledForDisacrding`
2. rename `stateDiscarded` -> `discarded`
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
