tillrohrmann commented on a change in pull request #13583:
URL: https://github.com/apache/flink/pull/13583#discussion_r503814304
##########
File path:
flink-clients/src/main/java/org/apache/flink/client/deployment/application/ApplicationDispatcherGatewayServiceFactory.java
##########
@@ -92,6 +91,7 @@ public ApplicationDispatcherGatewayServiceFactory(
throw new FlinkRuntimeException("Could not create the
Dispatcher rpc endpoint.", e);
}
+ bootstrap.setErrorHandler(exception ->
dispatcher.getShutDownFuture().completeExceptionally(exception));
Review comment:
I don't understand the chicken-egg problem here. Why don't we pass in a
bootstrap factory which creates the `ApplicationDispatcherBootstrap` with the
appropriate fatal error handler when `Dispatcher.onStart` is being called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
