SteNicholas commented on a change in pull request #13572:
URL: https://github.com/apache/flink/pull/13572#discussion_r503821712
##########
File path: flink-python/pyflink/common/typeinfo.py
##########
@@ -70,6 +72,18 @@ def __hash__(self) -> int:
def __str__(self):
return self._j_typeinfo.toString()
+ def need_conversion(self):
+ """
+ Does this type need to conversion between Python object and internal
Wrapper object.
+ """
+ return False
+
+ def to_wrapper_type(self, obj):
Review comment:
@dianfu OK. I would like to rename `to_wrapper_type` to
`to_internal_type `.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
