zentol commented on pull request #13599: URL: https://github.com/apache/flink/pull/13599#issuecomment-707797401
That's definitelx _better_, but we're still just fighting symptoms. The underlying problem isn't shading, but dependency management (annoyingly) not being visible to consumers of a module. So when flink-dist comes around it sees the original transitive dependencies. If we were to explicitly declare dependencies on snakeyaml in the modules that currently use dependency management this problem would also go away, but there are also downsides since it obfuscates the dependency tree which is really annoying. Essentially, dependency management should be defined where they cover all relevant modules and consumers, which for us, in the case of flink-dist, is unfortunately the root pom. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
