zentol commented on pull request #13514: URL: https://github.com/apache/flink/pull/13514#issuecomment-708213046
@jerrypeng I just tried it myself and escaping `+` with `%2B` did work for me. Overall, I do see the convenience aspect of not requiring anything to be escaped by removing all special characters (after all that's why we are already removing characters), but I'm wondering whether it wouldn't be better if the metric names were exactly what users have defined in their API. While several reporters do indeed remove characters, that's because their respective back-end straight-up doesn't support it. This is a different story with HTML, which very much can display everything as is, and we maybe shouldn't give that up. As such, I would be in favor of keeping all special characters and not remove anything in the `MetricQueryService`, and adjust the WebUI to properly escape the metric names when fetching them (because as it turns out, the WebUI cannot query these metrics as well). That said, I would be also fine with removing everything that is not alphanumeric, but I think this is a discussion for the mailing list. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
