zhuzhurk opened a new pull request #13628:
URL: https://github.com/apache/flink/pull/13628


   ## What is the purpose of the change
   
   This PR fixes the issue reported in FLINK-19552, that JM can crash if 
concurrent failures happens.
   The root cause is that `MergingSharedSlotProfileRetrieverFactory` 
incorrectly retrieves preferred locations for vertices which are not scheduled 
yet, while some of their producer vertex are canceled and so are their location 
futures.
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
     - *UTs in SlotSharingExecutionSlotAllocatorTest and 
MergingSharedSlotProfileRetrieverTest*
     - *IT: PipelinedRegionSchedulingConcurrentFailureTest*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / 
don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / 
JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to