Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1679#discussion_r53763441
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/api/scala/table/test/StringExpressionsITCase.scala
---
@@ -18,42 +18,20 @@
package org.apache.flink.api.scala.table.test
-import org.apache.flink.api.table.{Row, ExpressionException}
import org.apache.flink.api.scala._
import org.apache.flink.api.scala.table._
-import org.apache.flink.test.util.{TestBaseUtils, MultipleProgramsTestBase}
+import org.apache.flink.api.table.Row
import
org.apache.flink.test.util.MultipleProgramsTestBase.TestExecutionMode
+import org.apache.flink.test.util.{MultipleProgramsTestBase, TestBaseUtils}
import org.junit._
import org.junit.runner.RunWith
import org.junit.runners.Parameterized
+
import scala.collection.JavaConverters._
-import org.apache.flink.api.table.codegen.CodeGenException
@RunWith(classOf[Parameterized])
class StringExpressionsITCase(mode: TestExecutionMode) extends
MultipleProgramsTestBase(mode) {
- @Test(expected = classOf[CodeGenException])
--- End diff --
Why did you remove these tests? The `ScalarFunctionsTest` does not test the
feature end-to-end, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
