godfreyhe commented on a change in pull request #13280:
URL: https://github.com/apache/flink/pull/13280#discussion_r504616846
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/plan/optimize/StreamCommonSubGraphBasedOptimizer.scala
##########
@@ -178,7 +178,7 @@ class StreamCommonSubGraphBasedOptimizer(planner:
StreamPlanner)
def getMiniBatchInterval: MiniBatchInterval = miniBatchInterval
- override def needFinalTimeIndicatorConversion: Boolean = true
+ override def needFinalTimeIndicatorConversion: Boolean = false
Review comment:
should return `isSinkBlock` here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
