dawidwys commented on a change in pull request #13635: URL: https://github.com/apache/flink/pull/13635#discussion_r504625187
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/MultiInputTransformationTranslator.java ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.runtime.translators; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.ExecutionConfig; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.api.dag.Transformation; +import org.apache.flink.streaming.api.graph.SimpleTransformationTranslator; +import org.apache.flink.streaming.api.graph.StreamGraph; +import org.apache.flink.streaming.api.graph.TransformationTranslator; +import org.apache.flink.streaming.api.transformations.AbstractMultipleInputTransformation; +import org.apache.flink.streaming.api.transformations.KeyedMultipleInputTransformation; +import org.apache.flink.streaming.runtime.io.MultipleInputSelectionHandler; + +import java.util.Collection; +import java.util.Collections; +import java.util.List; + +import static org.apache.flink.util.Preconditions.checkArgument; +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * A {@link TransformationTranslator} for the {@link AbstractMultipleInputTransformation MultipleInputTransformations}. Review comment: I find the link a bit weird and misleading. I'd either link to `AbstractMultipleInputTransformation` or to both the `MultipleInputTransformations` and `KeyedMultipleInputTransformations`. ########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/translators/MultiInputTransformationTranslator.java ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.runtime.translators; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.ExecutionConfig; +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.api.dag.Transformation; +import org.apache.flink.streaming.api.graph.SimpleTransformationTranslator; +import org.apache.flink.streaming.api.graph.StreamGraph; +import org.apache.flink.streaming.api.graph.TransformationTranslator; +import org.apache.flink.streaming.api.transformations.AbstractMultipleInputTransformation; +import org.apache.flink.streaming.api.transformations.KeyedMultipleInputTransformation; +import org.apache.flink.streaming.runtime.io.MultipleInputSelectionHandler; + +import java.util.Collection; +import java.util.Collections; +import java.util.List; + +import static org.apache.flink.util.Preconditions.checkArgument; +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * A {@link TransformationTranslator} for the {@link AbstractMultipleInputTransformation MultipleInputTransformations}. + * + * @param <OUT> The type of the elements that result from this {@code MultipleInputTransformation} + */ +@Internal +public class MultiInputTransformationTranslator<OUT> + extends SimpleTransformationTranslator<OUT, AbstractMultipleInputTransformation<OUT>> { + + @Override + protected Collection<Integer> translateForBatchInternal( + final AbstractMultipleInputTransformation<OUT> transformation, + final Context context) { + return translateInternal(transformation, context); + } + + @Override + protected Collection<Integer> translateForStreamingInternal( + final AbstractMultipleInputTransformation<OUT> transformation, + final Context context) { + return translateInternal(transformation, context); + } + + private Collection<Integer> translateInternal( + final AbstractMultipleInputTransformation<OUT> transformation, + final Context context) { + checkNotNull(transformation); + checkNotNull(context); + + final List<Transformation<?>> inputTransformations = transformation.getInputs(); + checkArgument(!inputTransformations.isEmpty(), + "Empty inputs for MultipleInputTransformation. Did you forget to add inputs?"); + MultipleInputSelectionHandler.checkSupportedInputCount(inputTransformations.size()); + + final StreamGraph streamGraph = context.getStreamGraph(); + final String slotSharingGroup = context.getSlotSharingGroup(); + final int transformationId = transformation.getId(); + final ExecutionConfig executionConfig = streamGraph.getExecutionConfig(); + + streamGraph.addMultipleInputOperator( + transformationId, + slotSharingGroup, + transformation.getCoLocationGroupKey(), + transformation.getOperatorFactory(), + transformation.getInputTypes(), + transformation.getOutputType(), + transformation.getName()); + + final int parallelism = transformation.getParallelism() != ExecutionConfig.PARALLELISM_DEFAULT + ? transformation.getParallelism() + : executionConfig.getParallelism(); + streamGraph.setParallelism(transformationId, parallelism); + streamGraph.setMaxParallelism(transformationId, transformation.getMaxParallelism()); + + if (transformation instanceof KeyedMultipleInputTransformation) { + KeyedMultipleInputTransformation keyedTransform = (KeyedMultipleInputTransformation) transformation; Review comment: Fix warning: ```suggestion KeyedMultipleInputTransformation<OUT> keyedTransform = (KeyedMultipleInputTransformation<OUT>) transformation; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
