danny0405 commented on a change in pull request #13577:
URL: https://github.com/apache/flink/pull/13577#discussion_r505134603
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/functions/utils/AggSqlFunction.scala
##########
@@ -165,18 +165,28 @@ object AggSqlFunction {
}
}
- private[flink] def createOperandTypeChecker(
+ private[flink] def createOperandMetadata(
name: String,
aggregateFunction: ImperativeAggregateFunction[_, _],
externalAccType: DataType)
- : SqlOperandTypeChecker = {
+ : SqlOperandMetadata = {
val methods = checkAndExtractMethods(aggregateFunction, "accumulate")
/**
* Operand type checker based on [[AggregateFunction]] given information.
*/
- new SqlOperandTypeChecker {
+ new SqlOperandMetadata {
+ override def paramNames(): util.List[String] = {
+ // Does not support named parameters.
+ Collections.emptyList()
Review comment:
What's the difference ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
