xintongsong commented on a change in pull request #13592:
URL: https://github.com/apache/flink/pull/13592#discussion_r505186609
##########
File path:
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManagerDriver.java
##########
@@ -170,8 +159,12 @@ protected void initializeInternal() throws Exception {
resourceManagerClient.start();
final RegisterApplicationMasterResponse
registerApplicationMasterResponse = registerApplicationMaster();
-
getContainersFromPreviousAttempts(registerApplicationMasterResponse);
-
updateMatchingStrategy(registerApplicationMasterResponse);
+ int maxPriority =
getContainersFromPreviousAttempts(registerApplicationMasterResponse);
+ taskExecutorProcessSpecContainerResourcePriorityAdapter
=
+ new
TaskExecutorProcessSpecContainerResourcePriorityAdapter(
+ maxPriority + 1,
Review comment:
Should not be a problem. Yarn does not have constraints on the max
priority value, as long as it does not grow lager than `Integer#MAX_VALUE`. In
addition, we had this increasing priorities in Blink for years without any
problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
