XComp commented on a change in pull request #13547:
URL: https://github.com/apache/flink/pull/13547#discussion_r505388160
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/slot/TaskSlotTable.java
##########
@@ -246,10 +256,11 @@ default int freeSlot(AllocationID allocationId) throws
SlotNotFoundException {
/**
* Return an iterator over all tasks for a given job.
*
- * @param jobId identifying the job of the requested tasks
+ * @param jobId identifying the job of the requested tasks. If {@code
null} is passed,
+ * all tasks held by this {@code TaskSlotTable} are returned.
* @return Iterator over all task for a given job
*/
- Iterator<T> getTasks(JobID jobId);
+ Iterator<T> getTasks(@Nullable JobID jobId);
Review comment:
See [my comment
below](https://github.com/apache/flink/pull/13547#discussion_r505387654).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
