[
https://issues.apache.org/jira/browse/FLINK-3434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159051#comment-15159051
]
ASF GitHub Bot commented on FLINK-3434:
---------------------------------------
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1695#issuecomment-187748356
+1 to merge
> Return value from flinkYarnClient#deploy() should be checked against null
> -------------------------------------------------------------------------
>
> Key: FLINK-3434
> URL: https://issues.apache.org/jira/browse/FLINK-3434
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Chesnay Schepler
> Priority: Minor
>
> In CliFrontend#getClient() :
> {code}
> yarnCluster = flinkYarnClient.deploy();
> yarnCluster.connectToCluster();
> {code}
> Looking at FlinkYarnClientBase#deployInternal(), null return is possible:
> {code}
> try {
>
> org.apache.flink.core.fs.FileSystem.setDefaultScheme(flinkConfiguration);
> } catch (IOException e) {
> LOG.error("Error while setting the default " +
> "filesystem scheme from configuration.", e);
> return null;
> }
> {code}
> We should check the return from deploy() before calling connectToCluster().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
