dawidwys commented on a change in pull request #13647:
URL: https://github.com/apache/flink/pull/13647#discussion_r506144173
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamNode.java
##########
@@ -336,12 +336,11 @@ public void setUserHash(String userHash) {
this.userHash = userHash;
}
- @VisibleForTesting
public void setSortedInputs(boolean sortedInputs) {
this.sortedInputs = sortedInputs;
}
- boolean getSortedInputs() {
+ public boolean getSortedInputs() {
Review comment:
I made this change because I found it strange that `setSortedInputs`
(which is a more concerning method) is `public` and the corresponding getter is
in the default scope.
The setter must be `public` because it is used in `BatchExecutionUtils` in
`org.apache.flink.streaming.runtime.translators` package.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
