kl0u commented on a change in pull request #13656:
URL: https://github.com/apache/flink/pull/13656#discussion_r506151605
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraphGenerator.java
##########
@@ -244,19 +245,30 @@ private void configureStreamGraph(final StreamGraph
graph) {
}
private boolean shouldExecuteInBatchMode(final RuntimeExecutionMode
configuredMode) {
+ final boolean existsUnboundedSource = existsContinuousSource();
+
+ if (configuredMode == RuntimeExecutionMode.BATCH &&
existsUnboundedSource) {
Review comment:
Was also not decided on that. I went with `argument` because it is
something set by the user. But it may make sense to put `state` because
`argument` seems more mild.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
