Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/1668#issuecomment-187825999
Thanks @tillrohrmann for the feedback!
I merged `ForwardingOneInputTask` into `StreamIterationSink`.
One more think I missed pointing out is that when the iteration timeout
occurs the `StreamIterationHead` flushes its log to its output before
terminating. An alternative take would be to delay termination until the
barrier arrives back to complete the snapshot. The problem with that version,
even though it's correct, is that under frequent checkpoint intervals the
iteration head could potentially never terminate because it will always be in
snapshotting state when the timeout occurs.
Regarding the state snapshotting, should I switch to using the ListState
representation instead or does it make no difference for the time being?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
