[
https://issues.apache.org/jira/browse/FLINK-19698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216393#comment-17216393
]
Jiangjie Qin commented on FLINK-19698:
--------------------------------------
[~sewen] What do you think about these two changes? I'll reply to the FLIP-27
voting thread to let the folks who have voted to know these API change to the
Source API and update the FLIP-27 WIKI page once we reach consensus in this
ticket.
> Add close() method and onCheckpointComplete() to the Source.
> ------------------------------------------------------------
>
> Key: FLINK-19698
> URL: https://issues.apache.org/jira/browse/FLINK-19698
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Common
> Affects Versions: 1.11.2
> Reporter: Jiangjie Qin
> Assignee: Jiangjie Qin
> Priority: Major
>
> Right now there are some caveats to the new Source API. From the
> implementation of some connectors. We would like to make the following
> improvements to the current Source API.
> # Add the following method to the {{SplitReader}} API.
> {{public void close() throws Exception；}}
> This method allows the SplitReader implementations to be closed properly when
> the split fetcher exits.
> # Add the following method to the {{SourceReader}} API.
> {{public void checkpointComplete(long checkpointId);}}
> This method allows the {{SourceReader}} to take some cleanup / reporting
> actions when a checkpoint has been successfully taken.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
