SteNicholas commented on a change in pull request #13676:
URL: https://github.com/apache/flink/pull/13676#discussion_r507660319



##########
File path: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStreamBuilder.java
##########
@@ -60,14 +59,28 @@
         */
        private final OutputTag<IN> lateDataOutputTag;
 
+       private boolean isProcessingTime;

Review comment:
       @aljoscha I previously consider the enum like `TimeCharacteristic`, but 
this enum is only used in this which makes little sense and confused for users 
in 1.11 version.

##########
File path: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/PatternStreamBuilder.java
##########
@@ -60,14 +59,28 @@
         */
        private final OutputTag<IN> lateDataOutputTag;
 
+       private boolean isProcessingTime;

Review comment:
       @aljoscha I previously considered the enum like `TimeCharacteristic`, 
but this enum is only used in this which makes little sense and confused for 
users in 1.11 version.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to