guoweiM commented on a change in pull request #13678: URL: https://github.com/apache/flink/pull/13678#discussion_r507873450
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/sink/GlobalStreamingCommitterOperator.java ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.streaming.runtime.operators.sink; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.annotation.VisibleForTesting; +import org.apache.flink.api.connector.sink.GlobalCommitter; +import org.apache.flink.core.io.SimpleVersionedSerializer; +import org.apache.flink.streaming.api.operators.BoundedOneInput; + +import java.util.ArrayList; +import java.util.List; + +/** + * Runtime {@link org.apache.flink.streaming.api.operators.StreamOperator} for executing {@link GlobalCommitter}. + * + * @param <CommT> The committable type of the {@link GlobalCommitter}. + * @param <GlobalCommT> The global committable type of the {@link GlobalCommitter}. + */ +@Internal +public final class GlobalStreamingCommitterOperator<CommT, GlobalCommT> extends AbstractStreamingCommitterOperator<CommT, GlobalCommT> + implements BoundedOneInput { + + /** Aggregate committables to global committables and commit the global committables to the external system. */ + private GlobalCommitter<CommT, GlobalCommT> globalCommitter; + + /** The current pending global committables. */ + private List<GlobalCommT> currentGlobalCommittables; + + private boolean endOfInput; + + GlobalStreamingCommitterOperator( + GlobalCommitter<CommT, GlobalCommT> globalCommitter, + SimpleVersionedSerializer<GlobalCommT> committableSerializer) { + super(globalCommitter, committableSerializer); + this.globalCommitter = globalCommitter; + this.endOfInput = false; + } + + @Override + void recoveredCommittables(List<GlobalCommT> committables) { + this.currentGlobalCommittables = globalCommitter.filterRecoveredCommittables(committables); + } + + @Override + List<GlobalCommT> preCommit() { + final List<GlobalCommT> result = computeCurrentGlobalCommittables(); + currentInputs = new ArrayList<>(); + currentGlobalCommittables = new ArrayList<>(); + return result; + } + + @Override + public void endInput() { + endOfInput = true; + } + + @Override + public void notifyCheckpointComplete(long checkpointId) throws Exception { + super.notifyCheckpointComplete(checkpointId); + if (endOfInput) { + globalCommitter.endOfInput(); + } + } + + private List<GlobalCommT> computeCurrentGlobalCommittables() { + final List<GlobalCommT> result = new ArrayList<>(); Review comment: I remove this method. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
