wangyang0918 commented on a change in pull request #13644:
URL: https://github.com/apache/flink/pull/13644#discussion_r508490184
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/KubeClientFactory.java
##########
@@ -71,7 +73,12 @@ public static FlinkKubeClient
fromConfiguration(Configuration flinkConfig) {
final KubernetesClient client = new
DefaultKubernetesClient(config);
- return new Fabric8FlinkKubeClient(flinkConfig, client,
KubeClientFactory::createThreadPoolForAsyncIO);
+ if (flinkKubeClient == null) {
+ flinkKubeClient = new Fabric8FlinkKubeClient(
+ flinkConfig, client,
KubeClientFactory::createThreadPoolForAsyncIO);
+ }
Review comment:
I second your idea and will revert this commit. Then we could leave the
shared `flinkKubeClient` as a follow-up optimization.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
